[PATCH 1/4] drm/amdgpu: Fix potential issue if reserve function is interrupted If amdgpu_bo_reserve function is interrupted by signal, amdgpu_bo_kunmap function is not called.

Christian König deathsimple at vodafone.de
Tue Apr 25 08:05:20 UTC 2017


All commit messages got mangled into the subject line.

You probably forgot the empty line between subject and commit message 
while creating the commit.

With that fixed the whole series is Reviewed-by: Christian König 
<christian.koenig at amd.com>.

Regards,
Christian.

Am 24.04.2017 um 20:29 schrieb Alex Xie:
> Change-Id: Ide2b3be6549b3afb8d6116094b5fff495b18addf
> Signed-off-by: Alex Xie <AlexBin.Xie at amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index a09ad3cf..051696d 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -350,7 +350,7 @@ static void amdgpu_vram_scratch_fini(struct amdgpu_device *adev)
>   	if (adev->vram_scratch.robj == NULL) {
>   		return;
>   	}
> -	r = amdgpu_bo_reserve(adev->vram_scratch.robj, false);
> +	r = amdgpu_bo_reserve(adev->vram_scratch.robj, true);
>   	if (likely(r == 0)) {
>   		amdgpu_bo_kunmap(adev->vram_scratch.robj);
>   		amdgpu_bo_unpin(adev->vram_scratch.robj);




More information about the amd-gfx mailing list