[PATCH 2/2] drm/amdgpu: Fix use of interruptible waiting

[Christian König]

Am 26.04.2017 um 03:17 schrieb Michel Dänzer:
> On 26/04/17 06:25 AM, Alex Xie wrote:
>> 1. The wait is short. There is not much benefit by
>> interruptible waiting.
>> 2. In this function and caller functions, the error
>> handling for such interrupt is complicated and risky.
>>
>> Change-Id: I289674ecd3f5ef20c93fe63e33df6d668b3c2edc
>> Signed-off-by: Alex Xie <AlexBin.Xie at amd.com>
>> ---
>>   drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
>> index 43082bf..c006cc4 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
>> @@ -227,7 +227,7 @@ int amdgpu_crtc_prepare_flip(
>>   	new_abo = gem_to_amdgpu_bo(obj);
>>   
>>   	/* pin the new buffer */
>> -	r = amdgpu_bo_reserve(new_abo, false);
>> +	r = amdgpu_bo_reserve(new_abo, true);
>>   	if (unlikely(r != 0)) {
>>   		DRM_ERROR("failed to reserve new abo buffer before flip\n");
>>   		goto cleanup;
>>
> I'm afraid we have no choice but to use interruptible here, because this
> code runs as part of an ioctl (DRM_IOCTL_MODE_PAGE_FLIP).

Yes, agree. But the error message is incorrect here and should be removed.

Christian.