[PATCH 1/2] drm/amdgpu: Fix use of interruptible waiting

Christian König deathsimple at vodafone.de
Wed Apr 26 08:34:46 UTC 2017


Am 25.04.2017 um 23:25 schrieb Alex Xie:
> There is no good mechanism to handle the corresponding error.
> When signal interrupt happens, unpin is not called.
> As a result, inside AMDGPU, the statistic of pin size will be wrong.
>
> Change-Id: I4a06a227c2757c447cec0058ace4b028553658a2
> Signed-off-by: Alex Xie <AlexBin.Xie at amd.com>

Reviewed-by: Christian König <christian.koenig at amd.com> for this one.

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> index 7cf226d..43082bf 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> @@ -172,7 +172,7 @@ void amdgpu_crtc_cleanup_flip_ctx(
>   		struct amdgpu_flip_work *work,
>   		struct amdgpu_bo *new_abo)
>   {
> -	if (unlikely(amdgpu_bo_reserve(new_abo, false) != 0)) {
> +	if (unlikely(amdgpu_bo_reserve(new_abo, true) != 0)) {
>   		DRM_ERROR("failed to reserve new abo in error path\n");
>   		amdgpu_flip_work_cleanup(work);
>   		return;




More information about the amd-gfx mailing list