[PATCH] Revert "drm/amdgpu: Refactor flip into prepare submit and submit. (v2)"

Christian König deathsimple at vodafone.de
Fri Apr 28 08:57:53 UTC 2017


Am 28.04.2017 um 10:48 schrieb Michel Dänzer:
> On 28/04/17 05:23 PM, Christian König wrote:
>> Am 28.04.2017 um 08:59 schrieb Michel Dänzer:
>>> On 27/04/17 07:04 PM, Christian König wrote:
>>>> Am 27.04.2017 um 10:18 schrieb Michel Dänzer:
>>>>> From: Michel Dänzer <michel.daenzer at amd.com>
>>>>>
>>>>> This reverts commit cb341a319f7e66f879d69af929c3dadfc1a8f31e.
>>>>>
>>>>> The purpose of the refactor was for amdgpu_crtc_prepare/submit_flip to
>>>>> be used by the DC code, but that's no longer the case.
>>>>>
>>>>> Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>
>>> [...]
>>>
>>>>> +pflip_cleanup:
>>>>> +    if (unlikely(amdgpu_bo_reserve(new_abo, false) != 0)) {
>>>> Well here we explicitly shouldn't use an interruptible wait, otherwise
>>>> we would keep the BO pinned.
>>> Makes sense, but this patch just reverts another commit and moves this
>>> code unchanged.
> Actually, after rebasing to current amd-staging-4.9, it already looks
> like you suggested. Can I get your Reviewed-by for that?

Yes, feel free to add my rb.

Christian.

>
>
>>> I'll send a follow-up patch which fixes this (possibly also in other
>>> error paths).
>> Sounds good, and feel free to CC me as well.
> Done.
>
>



More information about the amd-gfx mailing list