[PATCH 1/1] drm/amdgpu: Use list_del_init in amdgpu_mn_unregister

Felix Kuehling felix.kuehling at amd.com
Wed Aug 2 02:41:42 UTC 2017


Hi Christian,

Please apply this patch if you think this is the correct solution. This
is currently blocking the amd-kfd-staging merge from amd-staging-4.11.
Kent will try another merge tomorrow morning our time.

I'm quite sure this also breaks userptrs in the graphics driver.

Thanks,
  Felix


On 17-08-01 10:34 PM, Felix Kuehling wrote:
> Otherwise bo->shadow_list (which is aliased by bo->mn_list) will not
> appear empty in amdgpu_ttm_bo_destroy and cause an oops when freeing
> former userptr BOs.
>
> Signed-off-by: Felix Kuehling <Felix.Kuehling at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c
> index 38f739f..6558a3e 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c
> @@ -359,7 +359,7 @@ void amdgpu_mn_unregister(struct amdgpu_bo *bo)
>  	head = bo->mn_list.next;
>  
>  	bo->mn = NULL;
> -	list_del(&bo->mn_list);
> +	list_del_init(&bo->mn_list);
>  
>  	if (list_empty(head)) {
>  		struct amdgpu_mn_node *node;



More information about the amd-gfx mailing list