[PATCH 1/1] drm/amdgpu: Use list_del_init in amdgpu_mn_unregister

[Russell, Kent]

Things look good on initial testing on Fiji. Thanks Felix for the fix, and Christian for pushing it quickly.

 Kent

-----Original Message-----
From: Christian König [mailto:deathsimple at vodafone.de] 
Sent: Wednesday, August 02, 2017 3:01 AM
To: Kuehling, Felix; amd-gfx at lists.freedesktop.org; Koenig, Christian
Cc: Russell, Kent
Subject: Re: [PATCH 1/1] drm/amdgpu: Use list_del_init in amdgpu_mn_unregister

Hi Felix,

yeah, that looks like the correct solution.

Patch is Reviewed-by: Christian König <christian.koenig at amd.com> and I'm going to push it into amd-staging-4.11 ASAP.

Mpf, looks like I've actually tested this with the notifier disabled.

Thanks for the quick fix,
Christian.

Am 02.08.2017 um 04:41 schrieb Felix Kuehling:
> Hi Christian,
>
> Please apply this patch if you think this is the correct solution. 
> This is currently blocking the amd-kfd-staging merge from amd-staging-4.11.
> Kent will try another merge tomorrow morning our time.
>
> I'm quite sure this also breaks userptrs in the graphics driver.
>
> Thanks,
>    Felix
>
>
> On 17-08-01 10:34 PM, Felix Kuehling wrote:
>> Otherwise bo->shadow_list (which is aliased by bo->mn_list) will not 
>> appear empty in amdgpu_ttm_bo_destroy and cause an oops when freeing 
>> former userptr BOs.
>>
>> Signed-off-by: Felix Kuehling <Felix.Kuehling at amd.com>
>> ---
>>   drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c 
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c
>> index 38f739f..6558a3e 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c
>> @@ -359,7 +359,7 @@ void amdgpu_mn_unregister(struct amdgpu_bo *bo)
>>   	head = bo->mn_list.next;
>>   
>>   	bo->mn = NULL;
>> -	list_del(&bo->mn_list);
>> +	list_del_init(&bo->mn_list);
>>   
>>   	if (list_empty(head)) {
>>   		struct amdgpu_mn_node *node;
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx