[PATCH 2/2] drm/amd/powerplay: fix coding style in hwmgr.c

Deucher, Alexander Alexander.Deucher at amd.com
Tue Aug 8 15:03:05 UTC 2017


> -----Original Message-----
> From: amd-gfx [mailto:amd-gfx-bounces at lists.freedesktop.org] On Behalf
> Of Rex Zhu
> Sent: Tuesday, August 08, 2017 12:24 AM
> To: amd-gfx at lists.freedesktop.org
> Cc: Zhu, Rex
> Subject: [PATCH 2/2] drm/amd/powerplay: fix coding style in hwmgr.c
> 
> Change-Id: I1f31f90b9ed137eac72a7947f07f2d03af16cc7c
> Signed-off-by: Rex Zhu <Rex.Zhu at amd.com>

Series is:
Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c
> b/drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c
> index 1a70075..6eed634 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c
> @@ -582,26 +582,26 @@ int phm_get_sclk_for_voltage_evv(struct
> pp_hwmgr *hwmgr,
>  	phm_ppt_v1_voltage_lookup_table *lookup_table,
>  	uint16_t virtual_voltage_id, int32_t *sclk)
>  {
> -	uint8_t entryId;
> -	uint8_t voltageId;
> +	uint8_t entry_id;
> +	uint8_t voltage_id;
>  	struct phm_ppt_v1_information *table_info =
>  			(struct phm_ppt_v1_information *)(hwmgr-
> >pptable);
> 
>  	PP_ASSERT_WITH_CODE(lookup_table->count != 0, "Lookup table is
> empty", return -EINVAL);
> 
>  	/* search for leakage voltage ID 0xff01 ~ 0xff08 and sckl */
> -	for (entryId = 0; entryId < table_info->vdd_dep_on_sclk->count;
> entryId++) {
> -		voltageId = table_info->vdd_dep_on_sclk-
> >entries[entryId].vddInd;
> -		if (lookup_table->entries[voltageId].us_vdd ==
> virtual_voltage_id)
> +	for (entry_id = 0; entry_id < table_info->vdd_dep_on_sclk->count;
> entry_id++) {
> +		voltage_id = table_info->vdd_dep_on_sclk-
> >entries[entry_id].vddInd;
> +		if (lookup_table->entries[voltage_id].us_vdd ==
> virtual_voltage_id)
>  			break;
>  	}
> 
> -	if (entryId >= table_info->vdd_dep_on_sclk->count) {
> +	if (entry_id >= table_info->vdd_dep_on_sclk->count) {
>  		pr_debug("Can't find requested voltage id in
> vdd_dep_on_sclk table\n");
>  		return -EINVAL;
>  	}
> 
> -	*sclk = table_info->vdd_dep_on_sclk->entries[entryId].clk;
> +	*sclk = table_info->vdd_dep_on_sclk->entries[entry_id].clk;
> 
>  	return 0;
>  }
> --
> 1.9.1
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx


More information about the amd-gfx mailing list