[PATCH 4/4] drm/amdkfd: Implement image tiling mode support

Felix Kuehling felix.kuehling at amd.com
Mon Aug 14 15:18:33 UTC 2017


On 2017-08-13 05:08 AM, Oded Gabbay wrote:
> As in the previous patch, there is a hole here in the IOCTLs
> numbering. I suggest that when you upstream new IOCTLs, you will put
> them in consecutive numbers per the upstream driver, and then take
> that change downstream because you can easily change it in your
> driver.

We can easily change it downstream, but it makes it harder for people to
test the new upstream kernel with already released ROCm user mode
drivers that are easy to install and without having to wait a few weeks
for the next release.

If testability is not a priority, then I'd rather upstream the new
ioctls in the order in which we made them. The only reason I'm going
out-of-order is to make testing as easy as possible, as early as
possible, with the most recently released user mode stack.

It's your call, though.

Regards,
  Felix

>
> Oded



More information about the amd-gfx mailing list