[PATCH][drm-next] drm/amdgpu: remove duplicate return statement

Alex Deucher alexdeucher at gmail.com
Thu Aug 24 18:26:11 UTC 2017


On Wed, Aug 23, 2017 at 2:24 PM, Felix Kuehling <felix.kuehling at amd.com> wrote:
> I must have added that accidentally when cherry-picking an internal
> patch for upstreaming. Thanks for catching it.
>
> Reviewed-by: Felix Kuehling <Felix.Kuehling at amd.com>

Applied.  thanks!

Alex

>
> Regards,
>   Felix
>
>
> On 2017-08-23 09:17 AM, Colin King wrote:
>> From: Colin Ian King <colin.king at canonical.com>
>>
>> Remove a redundant identical return statement, it has no use.
>>
>> Detected by CoverityScan, CID#1454586 ("Structurally dead code")
>>
>> Signed-off-by: Colin Ian King <colin.king at canonical.com>
>> ---
>>  drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v8.c | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v8.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v8.c
>> index fb6e5dbd5a03..309f2419c6d8 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v8.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v8.c
>> @@ -155,7 +155,6 @@ static const struct kfd2kgd_calls kfd2kgd = {
>>  struct kfd2kgd_calls *amdgpu_amdkfd_gfx_8_0_get_functions(void)
>>  {
>>       return (struct kfd2kgd_calls *)&kfd2kgd;
>> -     return (struct kfd2kgd_calls *)&kfd2kgd;
>>  }
>>
>>  static inline struct amdgpu_device *get_amdgpu_device(struct kgd_dev *kgd)
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx


More information about the amd-gfx mailing list