[PATCH] drm/amdgpu: Add sysfs file for VBIOS

[Alex Deucher]

On Fri, Aug 25, 2017 at 8:59 AM, Russell, Kent <Kent.Russell at amd.com> wrote:
> There is GPU Power usage reported through amdgpu_pm_info, which also has some other information as well. I'd like that in sysfs, but I am unsure if we are  allowed to due to the other information reported there.
>

We can add a sysfs file for power info, but I'd like the keep the
debugfs one as well since we regularly change the format as we add
features and such.  Depending on what info you want to get, you may
already have what you need via the sysfs pp files.

Alex


>  Kent
>
> -----Original Message-----
> From: StDenis, Tom
> Sent: Friday, August 25, 2017 8:58 AM
> To: Christian König; Russell, Kent; amd-gfx at lists.freedesktop.org
> Subject: Re: [PATCH] drm/amdgpu: Add sysfs file for VBIOS
>
> On 25/08/17 08:56 AM, Christian König wrote:
>> Hi Kent,
>>
>> agree on the VBIOS dump file, that clearly belongs to debugsf.
>>
>> The power usage stuff I can't say much about cause I'm not deeply into
>> this, but keep in mind the restriction for sysfs:
>> 1. It's a stable interface. So it must be very well designed.
>> 2. Only one value per file. I think the power stuff doesn't fulfill
>> that requirement at the moment.
>
> What "power" stuff are we talking about?  The sensors interface or the pm_info or something else?
>
> Keep in mind umr uses the sensors debugfs file in --top mode.
>
> Tom
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx