[PATCH 14/14] drm/amd/amdgpu: Simplify gfx_v9_0_wait_for_idle()

[Alex Deucher]

On Thu, Aug 31, 2017 at 12:06 PM, Tom St Denis <tom.stdenis at amd.com> wrote:
> Signed-off-by: Tom St Denis <tom.stdenis at amd.com>

One comment on patch 3.  The rest are:
Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
> index 9445a8fd13ba..00f082b0838f 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
> @@ -2930,15 +2930,10 @@ static bool gfx_v9_0_is_idle(void *handle)
>  static int gfx_v9_0_wait_for_idle(void *handle)
>  {
>         unsigned i;
> -       u32 tmp;
>         struct amdgpu_device *adev = (struct amdgpu_device *)handle;
>
>         for (i = 0; i < adev->usec_timeout; i++) {
> -               /* read MC_STATUS */
> -               tmp = RREG32_SOC15(GC, 0, mmGRBM_STATUS) &
> -                       GRBM_STATUS__GUI_ACTIVE_MASK;
> -
> -               if (!REG_GET_FIELD(tmp, GRBM_STATUS, GUI_ACTIVE))
> +               if (gfx_v9_0_is_idle(handle))
>                         return 0;
>                 udelay(1);
>         }
> --
> 2.12.0
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx