[PATCH 1/7] drm/ttm:fix incorrect calculate on shrink_pages

Michel Dänzer michel at daenzer.net
Tue Dec 12 10:23:22 UTC 2017


BTW, in the shortlog (subject) there should always be a space after the
prefix's ":".


On 2017-12-12 10:46 AM, Monk Liu wrote:
> shrink_pages is in unit of Order after ttm_page_pool_free,
> but it is used by nr_free in next round so need change
> it into native page unit
> 
> Change-Id: I33b77ac1616e24b1b881eee54c3bd7342cfa9ab8
> Signed-off-by: Monk Liu <Monk.Liu at amd.com>
> ---
>  drivers/gpu/drm/ttm/ttm_page_alloc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/ttm/ttm_page_alloc.c b/drivers/gpu/drm/ttm/ttm_page_alloc.c
> index 44343a2..71945cc 100644
> --- a/drivers/gpu/drm/ttm/ttm_page_alloc.c
> +++ b/drivers/gpu/drm/ttm/ttm_page_alloc.c
> @@ -455,6 +455,7 @@ ttm_pool_shrink_scan(struct shrinker *shrink, struct shrink_control *sc)
>  		freed += (nr_free_pool - shrink_pages) << pool->order;
>  		if (freed >= sc->nr_to_scan)
>  			break;
> +		shrink_pages <<= pool->order;
>  	}
>  	mutex_unlock(&lock);
>  	return freed;
> 

TTM patches need to be sent to the dri-devel list as well for review.
It's better not to mix TTM and amdgpu patches in the same series unless
absolutely necessary.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer


More information about the amd-gfx mailing list