[PATCH 1/3] drm/amdgpu: drop scratch regs save and restore from S3/S4 handling

Harry Wentland harry.wentland at amd.com
Tue Dec 12 23:52:12 UTC 2017


On 2017-12-12 03:27 PM, Alex Deucher wrote:
> The expectation is that the base driver doesn't mess with these.
> Some components interact with these directly so let the components
> handle these directly.
> 
> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>

Series is Reviewed-by: Harry Wentland <harry.wentland at amd.com>

Harry

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 98d62a991b67..ca1cf8a71dda 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -2577,7 +2577,6 @@ int amdgpu_device_suspend(struct drm_device *dev, bool suspend, bool fbcon)
>  	 */
>  	amdgpu_bo_evict_vram(adev);
>  
> -	amdgpu_atombios_scratch_regs_save(adev);
>  	pci_save_state(dev->pdev);
>  	if (suspend) {
>  		/* Shut down the device */
> @@ -2626,7 +2625,6 @@ int amdgpu_device_resume(struct drm_device *dev, bool resume, bool fbcon)
>  		if (r)
>  			goto unlock;
>  	}
> -	amdgpu_atombios_scratch_regs_restore(adev);
>  
>  	/* post card */
>  	if (amdgpu_need_post(adev)) {
> 


More information about the amd-gfx mailing list