[PATCH 1/6] drm/ttm: add on_alloc_stage and reservation into ttm_operation_ctx
Thomas Hellstrom
thomas at shipmail.org
Wed Dec 13 19:21:19 UTC 2017
Hi,
I think this series is quite poorly documented. We should have a log
message explaining the purpose of the commit.
Also since it's not obvious what the series is attempting to achieve,
please add a 0/X series header message..
/Thomas
On 12/12/2017 10:33 AM, Roger He wrote:
> on_alloc_stage: is this operation on allocation stage
> resv: reservation bo used of this operation
>
> Change-Id: I01ea482e8c7470014196eb218e2ff8913306eef0
> Signed-off-by: Roger He <Hongbo.He at amd.com>
> ---
> include/drm/ttm/ttm_bo_api.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/include/drm/ttm/ttm_bo_api.h b/include/drm/ttm/ttm_bo_api.h
> index 368eb02..25de597 100644
> --- a/include/drm/ttm/ttm_bo_api.h
> +++ b/include/drm/ttm/ttm_bo_api.h
> @@ -263,6 +263,8 @@ struct ttm_bo_kmap_obj {
> *
> * @interruptible: Sleep interruptible if sleeping.
> * @no_wait_gpu: Return immediately if the GPU is busy.
> + * @on_alloc_stage: is this operation on allocation stage
> + * @resv: resvation bo used
> *
> * Context for TTM operations like changing buffer placement or general memory
> * allocation.
> @@ -270,6 +272,8 @@ struct ttm_bo_kmap_obj {
> struct ttm_operation_ctx {
> bool interruptible;
> bool no_wait_gpu;
> + bool on_alloc_stage;
> + struct reservation_object *resv;
> uint64_t bytes_moved;
> };
>
More information about the amd-gfx
mailing list