[PATCH 02/30] drm/amd/display: Remove dead enable_plane function definition and call

[StDenis, Tom]

I tried the latest drm-next as of this morning and still had gfx corruption.

I added you to the watchers list for a JIRA ticket I opened about this.

Cheers,
Tom

________________________________________
From: Wentland, Harry
Sent: Thursday, December 14, 2017 10:41
To: StDenis, Tom; amd-gfx at lists.freedesktop.org
Subject: Re: [PATCH 02/30] drm/amd/display: Remove dead enable_plane function definition and call

On 2017-12-13 05:39 PM, Tom St Denis wrote:
> Would this fix the regression I found on Carrizo after the drm-next rebase?
>

This shouldn't have any functional impact. It was just a bit of unused code that we missed cleaning up in a previous change.

Regarding the regression you found, the fallout from 138a3358c179 (drm/amd/display: Optimize programming front end) should have been resolved a while ago. Do you still see issues with amd-staging-drm-next?

Harry

> Tom
>
>
>
> On December 13, 2017 5:34:34 PM EST, Harry Wentland <harry.wentland at amd.com> wrote:
>> Signed-off-by: Harry Wentland <harry.wentland at amd.com>
>> Reviewed-by: Jordan Lazare <Jordan.Lazare at amd.com>
>> Reviewed-by: Tony Cheng <Tony.Cheng at amd.com>
>> Acked-by: Harry Wentland <harry.wentland at amd.com>
>> ---
>> drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 3 ---
>> drivers/gpu/drm/amd/display/dc/inc/hw_sequencer.h           | 4 ----
>> 2 files changed, 7 deletions(-)
>>
>> diff --git
>> a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
>> b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
>> index 80d36610c302..f0002d63eb63 100644
>> --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
>> +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
>> @@ -2053,9 +2053,6 @@ enum dc_status dce110_apply_ctx_to_hw(
>>                              context,
>>                              dc);
>>
>> -            if (dc->hwss.enable_plane)
>> -                    dc->hwss.enable_plane(dc, pipe_ctx, context);
>> -
>>              if (DC_OK != status)
>>                      return status;
>>      }
>> diff --git a/drivers/gpu/drm/amd/display/dc/inc/hw_sequencer.h
>> b/drivers/gpu/drm/amd/display/dc/inc/hw_sequencer.h
>> index b6215ba514d8..5d2b05b93e76 100644
>> --- a/drivers/gpu/drm/amd/display/dc/inc/hw_sequencer.h
>> +++ b/drivers/gpu/drm/amd/display/dc/inc/hw_sequencer.h
>> @@ -138,10 +138,6 @@ struct hw_sequencer_funcs {
>>
>>      void (*disable_plane)(struct dc *dc, struct pipe_ctx *pipe_ctx);
>>
>> -    void (*enable_plane)(struct dc *dc,
>> -                    struct pipe_ctx *pipe,
>> -                    struct dc_state *context);
>> -
>>      void (*update_info_frame)(struct pipe_ctx *pipe_ctx);
>>
>>      void (*enable_stream)(struct pipe_ctx *pipe_ctx);
>> --
>> 2.14.1
>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
>