[PATCH] Release the mutex hold before backtracing for not supported mxgpu.
Yu, Xiangliang
Xiangliang.Yu at amd.com
Wed Dec 20 02:44:08 UTC 2017
> This patch releases the mutex held soon before entering the initialization
> function in case the device doesn't support mxgpu.
>
> Signed-off-by: José Pekkarinen <koalinux at gmail.com>
> ---
> drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c
> b/drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c
> index c25a831f94ec..cac1d8b003e6 100644
> --- a/drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c
> +++ b/drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c
> @@ -307,6 +307,7 @@ void xgpu_vi_init_golden_registers(struct
> amdgpu_device *adev)
>
> xgpu_tonga_golden_common_all));
> break;
> default:
> + mutex_unlock(&adev->grbm_idx_mutex);
> BUG_ON("Doesn't support chip type.\n");
> break;
> }
The release mutex in here has no meaning as kernel will hang later. And Alex has submitted patch to check ASIC IP during detecting SRIOV, so we can't see the case anymore. Please drop the patch.
Thanks!
> --
> 2.13.6
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
More information about the amd-gfx
mailing list