[PATCH] drm/amd/display: Fix MST physical ports always disconnected

Harry Wentland harry.wentland at amd.com
Tue Feb 7 00:01:34 UTC 2017


We finally were able to give this patch a spin. It looks good, although
we still have a ton of MST problems.

Reviewed-by: Harry Wentland <harry.wentland at amd.com>

You can find it on
https://cgit.freedesktop.org/~hwentland/linux/log/?h=amd-staging-dc-4.9

Harry

On 2017-01-27 12:58 PM, Krzysztof Nowicki wrote:
> From: Krzysztof Nowicki <krzysztof.a.nowicki at gmail.com>
> 
> Remove a false assumption that a cached EDID will be present whenever
> the connector is in a connected state as this will only be true for
> logical MST ports. For physical ports the EDID will never be cached,
> which will cause them to always appear as disconnected.
> 
> This reverts commit 4ff8a88888de271bfb7750b2a5c68163848e2bf1
> ---
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> index 6909dc8..937558d 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> @@ -127,14 +127,6 @@ dm_dp_mst_detect(struct drm_connector *connector, bool force)
>  			&master->mst_mgr,
>  			aconnector->port);
>  
> -	/*
> -	 * we do not want to make this connector connected until we have edid on
> -	 * it
> -	 */
> -	if (status == connector_status_connected &&
> -		!aconnector->port->cached_edid)
> -		status = connector_status_disconnected;
> -
>  	return status;
>  }
>  
> 


More information about the amd-gfx mailing list