[bug report] drm/amdgpu/virt: implement VI virt operation interfaces

[Yu, Xiangliang]

Thanks! I'll fix it.


Thanks!
Xiangliang Yu


> -----Original Message-----
> From: Dan Carpenter [mailto:dan.carpenter at oracle.com]
> Sent: Monday, February 06, 2017 7:19 PM
> To: Yu, Xiangliang <Xiangliang.Yu at amd.com>
> Cc: amd-gfx at lists.freedesktop.org
> Subject: [bug report] drm/amdgpu/virt: implement VI virt operation
> interfaces
> 
> Hello Xiangliang Yu,
> 
> The patch ab71ac56f6d8: "drm/amdgpu/virt: implement VI virt operation
> interfaces" from Jan 12, 2017, leads to the following static checker
> warning:
> 
> 	drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c:310
> xgpu_vi_init_golden_registers()
> 	warn: string literals are always true.
> 
> drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c
>    294                  break;
>    295          case CHIP_TONGA:
>    296                  amdgpu_program_register_sequence(adev,
>    297                                                   xgpu_tonga_mgcg_cgcg_init,
>    298                                                   (const u32)ARRAY_SIZE(
>    299                                                   xgpu_tonga_mgcg_cgcg_init));
>    300                  amdgpu_program_register_sequence(adev,
>    301                                                   xgpu_tonga_golden_settings_a11,
>    302                                                   (const u32)ARRAY_SIZE(
>    303                                                   xgpu_tonga_golden_settings_a11));
>    304                  amdgpu_program_register_sequence(adev,
>    305                                                   xgpu_tonga_golden_common_all,
>    306                                                   (const u32)ARRAY_SIZE(
>    307                                                   xgpu_tonga_golden_common_all));
>    308                  break;
>    309          default:
>    310                  BUG_ON("Doesn't support chip type.\n");
> 
> BUG_ON() takes a condition argument, not a format string.
> 
>    311                  break;
>    312          }
>    313  }
> 
> regards,
> dan carpenter