[PATCH] Autodetect libdrm path (v2)
Tom St Denis
tom.stdenis at amd.com
Tue Feb 7 11:30:44 UTC 2017
On 07/02/17 06:02 AM, Emil Velikov wrote:
> On 6 February 2017 at 22:39, StDenis, Tom <Tom.StDenis at amd.com> wrote:
>> Apparently I missed the bottom of your reply (all of the clients I have outlook/gmail do top post only ...)
> Both Outlook and Gmail can do inline replies and plain text. There
> might be some magic required for the former though :-\
> I would kindly suggest using inline/text when possible.
You'll be pleased to note I discovered (at some point) that AMD has
re-enabled imap support and I can now use a more sensible client...
>> Ironically, I had the pkg_check originally but was told that's a faux-pas.
> It's a common misconception, influenced by the sheer volume of copy/paste :-)
>> Unless this is breaking for actual users though it's not really a priority to bikeshed the build system of a 30 file project that is meant to work only on developer machines who are likely building for themselves
> Up-to you really. FWIW using cmake/autoconf/etc. is a huge overkill.
> The original makefile was missing a few things* worth 10-20 lines of
> code while being noticeably smaller, quicker and easier to read ;-)
To be honest unless the cmake system gets in the way I'm happy if it
makes others happy. It's not easy to say the project is "open" if we
NAK any and all harmless commits that the users advocate for.
The official stance from AMD (specifically the team I work for) is if
cmake gets in the way of AMD work we will nuke the cmake system and go
back to gmake (with pkg-config shell calls to get paths).
Personally I'm not a big fan of overly complicated config/build systems
but since I don't do package building/etc for a living I'll defer to the
opinions of others within reason.
>> Also umr can read/write registers via pci access without amdgpu loaded (handy if amdgpu fails to init properly).
> Must have missed this part. Thanks for the correction.
Yup, you can force device + direct access, e.g.
umr -O use_pci -f fiji -r *.uvd5.mmFOO
Which is handy like I said if the module init fails. Developers also
use it in NPI bringup to poke things.
More information about the amd-gfx