[patch] drm/radeon: remove some dead code

[Michel Dänzer]

On 07/02/17 10:16 PM, Dan Carpenter wrote:
> If "rdev->bios" is NULL then we don't need to free it.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
> 
> diff --git a/drivers/gpu/drm/radeon/radeon_bios.c b/drivers/gpu/drm/radeon/radeon_bios.c
> index 00cfb5d2875f..04c0ed41374f 100644
> --- a/drivers/gpu/drm/radeon/radeon_bios.c
> +++ b/drivers/gpu/drm/radeon/radeon_bios.c
> @@ -638,10 +638,8 @@ static bool radeon_acpi_vfct_bios(struct radeon_device *rdev)
>  					     vhdr->ImageLength,
>  					     GFP_KERNEL);
>  
> -			if (!rdev->bios) {
> -				kfree(rdev->bios);
> +			if (!rdev->bios)
>  				return false;
> -			}
>  			return true;

Could be simplified further to

			return rdev->bios != NULL;

or maybe

			return !!rdev->bios;

Either way,

Reviewed-by: Michel Dänzer <michel.daenzer at amd.com>


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer