[PATCH 2/2] drm/amdgpu: use amdgpu_gem_va_check() in amdgpu_gem_va_update_vm()

Christian König deathsimple at vodafone.de
Fri Feb 10 10:02:28 UTC 2017


Am 09.02.2017 um 23:28 schrieb Samuel Pitoiset:
> This removes code duplication.
>
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>

Reviewed-by: Christian König <christian.koenig at amd.com>.

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 8 +-------
>   1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
> index ae4658a10e2c..76569e31bfd8 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
> @@ -506,13 +506,7 @@ static void amdgpu_gem_va_update_vm(struct amdgpu_device *adev,
>   	list_for_each_entry(entry, list, head) {
>   		struct amdgpu_bo *bo =
>   			container_of(entry->bo, struct amdgpu_bo, tbo);
> -
> -		/* if anything is swapped out don't swap it in here,
> -		   just abort and wait for the next CS */
> -		if (!amdgpu_bo_gpu_accessible(bo))
> -			goto error;
> -
> -		if (bo->shadow && !amdgpu_bo_gpu_accessible(bo->shadow))
> +		if (amdgpu_gem_va_check(NULL, bo))
>   			goto error;
>   	}
>   




More information about the amd-gfx mailing list