[PATCH 0/8] Refactor DC atomic commit and gamma

Alex Deucher alexdeucher at gmail.com
Fri Feb 10 16:07:08 UTC 2017


On Thu, Feb 9, 2017 at 4:41 PM, Harry Wentland <harry.wentland at amd.com> wrote:
> These patches are first steps of addressing some of the problems
> in DC's atomic implementation. Please take a look and provide
> feedback if possible. Our hope is that we can start setting a
> direction on fixing up DC to do atomic correctly and lay the
> groundwork for moving past the midlayer.
>
> THe biggest patch here is Andrey's work to bring atomic_commit
> in line with the atomic helpers instead of rolling our own. We
> got atomic_commmit_tail now and things appear to work correctly
> with this change. It allowed us to clean up some of the commit
> code, but there's still a lot left.
>
> The second important patch is fixing up our gamma implementation
> and correct the use of crtc_set_property and atomic_set_properties.
>
> Beyond that there's some minor cleanup and support patches for
> the above change.
>
> The whole DC tree with these patches and rebased on drm-next a couple
> days ago can be found at
>
> https://cgit.freedesktop.org/~hwentland/linux/log/?h=dc-drm-next-atomic
>
> Known issue:
>   - corruption on one display in two-display setup
>
> Cheers,
> Harry


Harry, can you please resend this series and add dri-devel as well so
the discussion happens in a larger forum in case others working on
atomic have similar questions?

Thanks,

Alex

>
> Andrey Grodzovsky (3):
>   drm/amdgpu: Add a few members to support DAL atomic refactor.
>   drm/amd/display: Refactor atomic commit implementation.
>   drm/amd/display: Refactor headless to use atomic commit.
>
> Harry Wentland (5):
>   drm/amdgpu: Expose mode_config functions for DM
>   drm/amd/display: Use amdgpu mode funcs statically
>   drm/amd/display: Use atomic helpers for gamma
>   drm/amd/display: Remove unused define from amdgpu_dm_types
>   Revert "drm/amdgpu: Refactor flip into prepare submit and submit.
>     (v3)"
>
>  drivers/gpu/drm/amd/amdgpu/amdgpu_display.c        | 140 ++----
>  drivers/gpu/drm/amd/amdgpu/amdgpu_display.h        |  33 ++
>  drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h           |  19 +-
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c  |  70 ++-
>  .../drm/amd/display/amdgpu_dm/amdgpu_dm_types.c    | 548 +++++++++------------
>  .../drm/amd/display/amdgpu_dm/amdgpu_dm_types.h    |  12 +-
>  6 files changed, 341 insertions(+), 481 deletions(-)
>  create mode 100644 drivers/gpu/drm/amd/amdgpu/amdgpu_display.h
>
> --
> 2.9.3
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx


More information about the amd-gfx mailing list