[PATCH] drm/amd/display: Fix 64-bit division, yet again

Harry Wentland harry.wentland at amd.com
Wed Feb 15 14:47:05 UTC 2017

On 2017-02-15 06:44 AM, Emil Velikov wrote:
> On 14 February 2017 at 20:36, Harry Wentland <harry.wentland at amd.com> wrote:
>> Also make the code somewhat more readable.
> I'd suggest reaching to the team to integrate scripts/checkpatch.pl in
> the pre-commit hook.
> It will help you improve the coding standard and, as you mentioned, it
> "make[s] the code somewhat more readable".

Thanks, Emil. We actually have that hooked up at pre-submission in our 
internal repo but don't block submission on warnings and allow a couple 
people to push anyways despite errors because we seem to get some 
unnecessary errors on complex macros that can't really be handled 

Need to think on how to improve that. It's a pain being the bad guy 
constantly and people don't always see the importance of good coding and 
commit msg style.


> -Emil

More information about the amd-gfx mailing list