[PATCH] amdgpu/powerplay: Fixup printk() usage in pp_debug.h

Edward O'Callaghan funfunctor at folklore1984.net
Sat Feb 18 04:38:38 UTC 2017


disregard this, sorry for the noise.

On 02/16/2017 07:42 PM, Edward O'Callaghan wrote:
> We should properly prefix which kernel module this spewed
> from in dmesg for consistency to the user.
> 
> Signed-off-by: Edward O'Callaghan <funfunctor at folklore1984.net>
> ---
>  drivers/gpu/drm/amd/powerplay/inc/pp_debug.h | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/powerplay/inc/pp_debug.h b/drivers/gpu/drm/amd/powerplay/inc/pp_debug.h
> index bfdbec1..e4fad15 100644
> --- a/drivers/gpu/drm/amd/powerplay/inc/pp_debug.h
> +++ b/drivers/gpu/drm/amd/powerplay/inc/pp_debug.h
> @@ -28,12 +28,12 @@
>  #include <linux/kernel.h>
>  #include <linux/slab.h>
>  
> -#define PP_ASSERT_WITH_CODE(cond, msg, code)	\
> -	do {					\
> -		if (!(cond)) {			\
> -			printk("%s\n", msg);	\
> -			code;			\
> -		}				\
> +#define PP_ASSERT_WITH_CODE(cond, msg, code)		\
> +	do {						\
> +		if (!(cond)) {				\
> +			pr_error("amdgpu: %s\n", msg);	\
> +			code;				\
> +		}					\
>  	} while (0)
>  
>  
> 


More information about the amd-gfx mailing list