[PATCH 00/11] remove fb_location programming

[Zhang, Jerry]

> -----Original Message-----
> From: Alex Deucher [mailto:alexdeucher at gmail.com]
> Sent: Tuesday, February 21, 2017 22:38
> To: Zhang, Jerry
> Cc: amd-gfx list; Deucher, Alexander
> Subject: Re: [PATCH 00/11] remove fb_location programming
> 
> On Tue, Feb 21, 2017 at 1:47 AM, Zhang, Jerry <Jerry.Zhang at amd.com> wrote:
> > Hi Alex,
> >
> > The series of patch is Reviewed-by: Junwei Zhang <Jerry.Zhang at amd.com>
> >
> >> Tested this on CI and VI.  Works fine with DAL/DC. With the legacy
> >> display path, VCE fails to initialize (ECPU won't come out of reset).
> >> Any ideas?
> >
> > Did you met the issue in VI?
> 
> Yes.
> 
> > It looks that you're missing vce v3.0 changes for mc_resume.
> > Please confirm it.
> 
> What changes did you have in mind?  The changes for vce2.0 are not necessary
> for vce3.0 since it was programmed properly from the beginning as far as I
> understand it.

Hi Alex,

I thought vce3.0 had similar issue about BAR programming.
After checking, only vce2.0 needs this change indeed.
Sorry for misleading.

> 
> Alex
> 
> >
> > Regards,
> > Jerry (Junwei Zhang)
> >
> > Linux Base Graphics
> > SRDC Software Development
> > _____________________________________
> >
> >
> >> -----Original Message-----
> >> From: amd-gfx [mailto:amd-gfx-bounces at lists.freedesktop.org] On
> >> Behalf Of Alex Deucher
> >> Sent: Saturday, February 18, 2017 7:08
> >> To: amd-gfx list
> >> Cc: Deucher, Alexander
> >> Subject: Re: [PATCH 00/11] remove fb_location programming
> >>
> >> On Fri, Feb 17, 2017 at 3:38 PM, Alex Deucher <alexdeucher at gmail.com>
> wrote:
> >> > Since evergreen, the vbios has programmed the FB_LOCATION to the
> >> > proper size during asic_init, so there is no need to reprogram them in the
> driver.
> >> > We can safely leave the location as set by the vbios.  This
> >> > simplifies the driver significantly.
> >>
> >> Tested this on CI and VI.  Works fine with DAL/DC. With the legacy
> >> display path, VCE fails to initialize (ECPU won't come out of reset).
> >> Any ideas?
> >>
> >> Alex
> >>
> >> >
> >> > Alex Deucher (11):
> >> >   drm/amdgpu/vce2: fix vce bar programming
> >> >   drm/amdgpu: put gtt at 0 in the internal address space
> >> >   drm/amdgpu/gmc8: use the vram location programmed by the vbios
> >> >   drm/amdgpu/gmc7: use the vram location programmed by the vbios
> >> >   drm/amdgpu/gmc6: use the vram location programmed by the vbios
> >> >   drm/amdgpu/gmc8: drop fb location programming
> >> >   drm/amdgpu/gmc7: drop fb location programming
> >> >   drm/amdgpu/gmc6: drop fb location programming
> >> >   drm/amdgpu: drop set_vga_render_state from display funcs (v2)
> >> >   drm/amdgpu: remove *_mc_access from display funcs (v2)
> >> >   drm/amd/dc/dm: remove redundant display structs
> >> >
> >> >  drivers/gpu/drm/amd/amdgpu/amdgpu.h               |   4 -
> >> >  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c        |   8 +-
> >> >  drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h          |  12 --
> >> >  drivers/gpu/drm/amd/amdgpu/dce_v10_0.c            | 135 +---------------------
> >> >  drivers/gpu/drm/amd/amdgpu/dce_v10_0.h            |   6 -
> >> >  drivers/gpu/drm/amd/amdgpu/dce_v11_0.c            |  80 +------------
> >> >  drivers/gpu/drm/amd/amdgpu/dce_v11_0.h            |   6 -
> >> >  drivers/gpu/drm/amd/amdgpu/dce_v6_0.c             | 115 ------------------
> >> >  drivers/gpu/drm/amd/amdgpu/dce_v8_0.c             |  82 +------------
> >> >  drivers/gpu/drm/amd/amdgpu/dce_v8_0.h             |   6 -
> >> >  drivers/gpu/drm/amd/amdgpu/dce_virtual.c          |  97 +++++++---------
> >> >  drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c             |  38 ++----
> >> >  drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c             |  35 ++----
> >> >  drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c             |  34 ++----
> >> >  drivers/gpu/drm/amd/amdgpu/vce_v2_0.c             |  17 +--
> >> >  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |  75
> >> > +-----------
> >> >  16 files changed, 83 insertions(+), 667 deletions(-)
> >> >
> >> > --
> >> > 2.5.5
> >> >
> >> _______________________________________________
> >> amd-gfx mailing list
> >> amd-gfx at lists.freedesktop.org
> >> https://lists.freedesktop.org/mailman/listinfo/amd-gfx