[PATCH 1/4] drm/amd/powerplay: Configuring DIDT blocks only SQ enabled on Polaris11.

[Zhu, Rex]

Hi Alex,

>>> This will set the caps on Polaris10 as well?  Intended?

Rex:  Yes, Currently, New didt messages were only supported on Polaris11. 

Best Regards
Rex
 
-----Original Message-----
From: Deucher, Alexander 
Sent: Monday, January 09, 2017 10:12 PM
To: Zhu, Rex; amd-gfx at lists.freedesktop.org
Cc: Zhu, Rex
Subject: RE: [PATCH 1/4] drm/amd/powerplay: Configuring DIDT blocks only SQ enabled on Polaris11.

> -----Original Message-----
> From: amd-gfx [mailto:amd-gfx-bounces at lists.freedesktop.org] On Behalf 
> Of Rex Zhu
> Sent: Monday, January 09, 2017 1:52 AM
> To: amd-gfx at lists.freedesktop.org
> Cc: Zhu, Rex
> Subject: [PATCH 1/4] drm/amd/powerplay: Configuring DIDT blocks only 
> SQ enabled on Polaris11.
> 
> following firmware's request.
> 
> Change-Id: I0098144cae57727999101152e973338ddffec28e
> Signed-off-by: Rex Zhu <Rex.Zhu at amd.com>
> ---
>  drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c | 21 ++++++++++++-----
> ----
>  1 file changed, 12 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c
> b/drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c
> index 2f6225e..2ea9c0e 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c
> @@ -767,17 +767,10 @@ int phm_get_voltage_evv_on_sclk(struct
> pp_hwmgr *hwmgr, uint8_t voltage_type,
> 
>  int polaris_set_asic_special_caps(struct pp_hwmgr *hwmgr)  {
> -	/* power tune caps Assume disabled */
> +
>  	phm_cap_set(hwmgr->platform_descriptor.platformCaps,
> 
> 	PHM_PlatformCaps_SQRamping);
>  	phm_cap_set(hwmgr->platform_descriptor.platformCaps,
> -
> 	PHM_PlatformCaps_DBRamping);
> -	phm_cap_set(hwmgr->platform_descriptor.platformCaps,
> -
> 	PHM_PlatformCaps_TDRamping);
> -	phm_cap_set(hwmgr->platform_descriptor.platformCaps,
> -
> 	PHM_PlatformCaps_TCPRamping);
> -
> -	phm_cap_set(hwmgr->platform_descriptor.platformCaps,
> 
> 	PHM_PlatformCaps_RegulatorHot);
> 
>  	phm_cap_set(hwmgr->platform_descriptor.platformCaps,
> @@ -786,9 +779,19 @@ int polaris_set_asic_special_caps(struct pp_hwmgr
> *hwmgr)
>  	phm_cap_set(hwmgr->platform_descriptor.platformCaps,
> 
> 	PHM_PlatformCaps_TablelessHardwareInterface);
> 
> -	if ((hwmgr->chip_id == CHIP_POLARIS11) || (hwmgr->chip_id ==
> CHIP_POLARIS12))
> +
> +	if (hwmgr->chip_id != CHIP_POLARIS10)
>  		phm_cap_set(hwmgr->platform_descriptor.platformCaps,
> 
> 	PHM_PlatformCaps_SPLLShutdownSupport);
> +
> +	if (hwmgr->chip_id != CHIP_POLARIS11) {

This will set the caps on Polaris10 as well?  Intended?

> +		phm_cap_set(hwmgr->platform_descriptor.platformCaps,
> +
> 	PHM_PlatformCaps_DBRamping);
> +		phm_cap_set(hwmgr->platform_descriptor.platformCaps,
> +
> 	PHM_PlatformCaps_TDRamping);
> +		phm_cap_set(hwmgr->platform_descriptor.platformCaps,
> +
> 	PHM_PlatformCaps_TCPRamping);
> +	}
>  	return 0;
>  }
> 
> --
> 1.9.1
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx