答复: [PATCH 2/2] drm/amdgpu/vi: fix mailbox irq mistake

[Liu, Monk]

Reviewed-by: Monk Liu <monk.liu at amd.com>

________________________________
发件人: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> 代表 Xiangliang Yu <Xiangliang.Yu at amd.com>
发送时间: 2017年1月18日 13:00:26
收件人: amd-gfx at lists.freedesktop.org
抄送: Yu, Xiangliang
主题: [PATCH 2/2] drm/amdgpu/vi: fix mailbox irq mistake

For virt, freed mailbox irq should be handled in hw fini, not hw
init. Correct it.

Signed-off-by: Xiangliang Yu <Xiangliang.Yu at amd.com>
---
 drivers/gpu/drm/amd/amdgpu/vi.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c b/drivers/gpu/drm/amd/amdgpu/vi.c
index 0c8f04e..89b0dfe 100644
--- a/drivers/gpu/drm/amd/amdgpu/vi.c
+++ b/drivers/gpu/drm/amd/amdgpu/vi.c
@@ -1136,9 +1136,6 @@ static int vi_common_hw_init(void *handle)
         /* enable the doorbell aperture */
         vi_enable_doorbell_aperture(adev, true);

-       if (amdgpu_sriov_vf(adev))
-               xgpu_vi_mailbox_put_irq(adev);
-
         return 0;
 }

@@ -1149,6 +1146,9 @@ static int vi_common_hw_fini(void *handle)
         /* enable the doorbell aperture */
         vi_enable_doorbell_aperture(adev, false);

+       if (amdgpu_sriov_vf(adev))
+               xgpu_vi_mailbox_put_irq(adev);
+
         return 0;
 }

--
2.7.4

_______________________________________________
amd-gfx mailing list
amd-gfx at lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20170118/2da25924/attachment-0001.html>