[PATCH libdrm 2/3] amdgpu: A new option to choose which device to run most tests

[Xie, AlexBin]

HI Emil,


See below.


Thanks,

Alex


________________________________
From: Emil Velikov <emil.l.velikov at gmail.com>
Sent: Friday, January 20, 2017 8:24 AM
To: Xie, AlexBin
Cc: amd-gfx mailing list
Subject: Re: [PATCH libdrm 2/3] amdgpu: A new option to choose which device to run most tests

On 19 January 2017 at 22:53, Alex Xie <AlexBin.Xie at amd.com> wrote:
> This can be used to test multiple GPUs
>
> Signed-off-by: Alex Xie <AlexBin.Xie at amd.com>
> ---
>  tests/amdgpu/amdgpu_test.c | 25 ++++++++++++++++++++-----
>  1 file changed, 20 insertions(+), 5 deletions(-)
>
> diff --git a/tests/amdgpu/amdgpu_test.c b/tests/amdgpu/amdgpu_test.c
> index e42ef9d..2437db4 100644
> --- a/tests/amdgpu/amdgpu_test.c
> +++ b/tests/amdgpu/amdgpu_test.c
> @@ -108,12 +108,14 @@ static void display_test_suites(void)
>
>
>  /** Help string for command line parameters */
> -static const char usage[] = "Usage: %s [-hl] [<-s <suite id>> [-t <test id>]]\n"
> -                               "where:\n"
> -                               "       l - Display all suites and their tests\n"
> -                               "       h - Display this help\n";
> +static const char usage[] =
> +       "Usage: %s [-hl] [<-s <suite id>> [-t <test id>]] [-d <device_id>]\n"
> +       "where:\n"
> +       "       l - Display all suites and their tests\n"
> +       "       d - Choose which device to run tests\n"
You want to elaborate on what you mean with "device" here.
Even if currently "card0 is my Kabini, card1 Hawaii, card2 other" that
may change upon reboot.
So although very nice to say "0,1, 2..." things are non-deterministic.

[Alex Bin Xie] Originally I just want to give a simple solution for people to swap to test another GPU device.
Every time amdgpu_test runs, it lists the device id and its information. I was thinking to improve this but such as adding an option to list the devices. So that the 0, 1 ,2 does not change if computer is not reboot. If 0, 1, 2 is not deterministic, I have to give up this human friendly interface...

How about choose the test device by bus ID?  I will add an option to list the devices with BUS ID (if people run drmdevice program, they know the information too). Then people can choose  device on which BUS ID to run the test. I will provide a new patch if there is no object to this.


-Emil
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20170120/4d59d461/attachment.html>