[PATCH 1/2] drm/amdgpu: fix 64bit shift for KV/KB

Felix Kuehling felix.kuehling at amd.com
Tue Jan 24 16:09:57 UTC 2017


Series reviewed by me as well:

Reviewed-by: Felix Kuehling <Felix.Kuehling at amd.com>


On 17-01-24 10:48 AM, Deucher, Alexander wrote:
>> -----Original Message-----
>> From: amd-gfx [mailto:amd-gfx-bounces at lists.freedesktop.org] On Behalf
>> Of Christian König
>> Sent: Tuesday, January 24, 2017 9:10 AM
>> To: amd-gfx at lists.freedesktop.org
>> Subject: [PATCH 1/2] drm/amdgpu: fix 64bit shift for KV/KB
>>
>> From: Christian König <christian.koenig at amd.com>
>>
>> Fixes "access stolen VRAM directly on KV/KB" otherwise that won't
>> work as expected with more than 4GB RAM.
>>
>> Signed-off-by: Christian König <christian.koenig at amd.com>
> Series is:
> Reviewed-by: Alex Deucher <alexander.deucher at amd.com>
>
>> ---
>>  drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c
>> b/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c
>> index ccce04d..8d05e0c 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c
>> @@ -378,7 +378,7 @@ static int gmc_v7_0_mc_init(struct amdgpu_device
>> *adev)
>>
>>  #ifdef CONFIG_X86_64
>>  	if (adev->flags & AMD_IS_APU) {
>> -		adev->mc.aper_base = RREG32(mmMC_VM_FB_OFFSET) <<
>> 22ULL;
>> +		adev->mc.aper_base =
>> ((u64)RREG32(mmMC_VM_FB_OFFSET)) << 22;
>>  		adev->mc.aper_size = adev->mc.real_vram_size;
>>  	}
>>  #endif
>> --
>> 2.5.0
>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx



More information about the amd-gfx mailing list