[PATCH 2/3] drm/amdgpu: fix missed asd bo free when hw_fini
Christian König
christian.koenig at amd.com
Tue Jul 4 07:20:31 UTC 2017
Am 04.07.2017 um 08:10 schrieb Huang Rui:
> Signed-off-by: Huang Rui <ray.huang at amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
> index 1469e6d..7b43c60 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
> @@ -446,6 +446,11 @@ static int psp_hw_fini(void *handle)
> amdgpu_bo_free_kernel(&psp->fence_buf_bo,
> &psp->fence_buf_mc_addr, &psp->fence_buf);
>
> + if (psp->asd_shared_bo)
> + amdgpu_bo_free_kernel(&psp->asd_shared_bo,
> + &psp->asd_shared_mc_addr,
> + &psp->asd_shared_buf);
> +
Good catch, but again please remove the "if".
With that fixed the patch is Reviewed-by: Christian König
<christian.koenig at amd.com>.
Regards,
Christian.
> kfree(psp->cmd);
> psp->cmd = NULL;
>
More information about the amd-gfx
mailing list