[PATCH 07/11] drm/amdgpu: rename GART to SYSVM

Christian König deathsimple at vodafone.de
Wed Jul 5 07:22:06 UTC 2017


Am 05.07.2017 um 02:57 schrieb Michel Dänzer:
> On 05/07/17 06:11 AM, Felix Kuehling wrote:
>> I'm afraid this will lead to more confusion when talking to different
>> teams in AMD. At least to me "GART" was always understood to be the
>> system-wide address translation table (VMID-0). The remnant from the
>> pre-GPUVM days. You're now calling that SYSVM, while all GPU-accessible
>> system memory is still called GTT.
>>
>> I think it would make more sense to call general GPU-mapped system
>> memory "SYSVM" or "GPUVM", and only call the global VMID-0 page table
>> "GART".
>>
>> But of course that would require changes in TTM and all TTM drivers, so
>> it's not a realistic option.
> FWIW, the string "GART" doesn't appear anywhere in TTM, so I think your
> idea is feasible.
Yeah, TTM calls the domain TT (for translation table I think). I think 
that this is a rather good naming, because it doesn't make any 
assumption what kind of translation table it is (AGP, GART, GPUVM etc...).

But using SYSVM or GPUVM as name for the TTM domain wouldn't work for 
the simple reason that this naming is completely AMD specific.

I've considered vmid0 as well, but that didn't looked good to me. 
"system VM" is at least what our hardware developers use in the VM 
documentation, but I'm not totally happy with using the name either.

So feel free to throw in ideas.

Regards,
Christian.


More information about the amd-gfx mailing list