[PATCH 1/4] drm/amdgpu: remove unncessary code in psp v10 ring init func

Deucher, Alexander Alexander.Deucher at amd.com
Fri Jul 14 14:40:55 UTC 2017


> -----Original Message-----
> From: amd-gfx [mailto:amd-gfx-bounces at lists.freedesktop.org] On Behalf
> Of Junwei Zhang
> Sent: Friday, July 14, 2017 6:42 AM
> To: amd-gfx at lists.freedesktop.org
> Cc: Zhang, Jerry
> Subject: [PATCH 1/4] drm/amdgpu: remove unncessary code in psp v10 ring
> init func
> 
> Signed-off-by: Junwei Zhang <Jerry.Zhang at amd.com>

Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  drivers/gpu/drm/amd/amdgpu/psp_v10_0.c | 20 --------------------
>  1 file changed, 20 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v10_0.c
> b/drivers/gpu/drm/amd/amdgpu/psp_v10_0.c
> index 8e0a24f..328c6f5 100644
> --- a/drivers/gpu/drm/amd/amdgpu/psp_v10_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/psp_v10_0.c
> @@ -111,7 +111,6 @@ int psp_v10_0_prep_cmd_buf(struct
> amdgpu_firmware_info *ucode, struct psp_gfx_cm
>  int psp_v10_0_ring_init(struct psp_context *psp, enum psp_ring_type
> ring_type)
>  {
>  	int ret = 0;
> -	unsigned int psp_ring_reg = 0;
>  	struct psp_ring *ring;
>  	struct amdgpu_device *adev = psp->adev;
> 
> @@ -131,25 +130,6 @@ int psp_v10_0_ring_init(struct psp_context *psp,
> enum psp_ring_type ring_type)
>  		return ret;
>  	}
> 
> -	/* Write low address of the ring to C2PMSG_69 */
> -	psp_ring_reg = lower_32_bits(ring->ring_mem_mc_addr);
> -	WREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_69,
> psp_ring_reg);
> -	/* Write high address of the ring to C2PMSG_70 */
> -	psp_ring_reg = upper_32_bits(ring->ring_mem_mc_addr);
> -	WREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_70,
> psp_ring_reg);
> -	/* Write size of ring to C2PMSG_71 */
> -	psp_ring_reg = ring->ring_size;
> -	WREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_71,
> psp_ring_reg);
> -	/* Write the ring initialization command to C2PMSG_64 */
> -	psp_ring_reg = ring_type;
> -	psp_ring_reg = psp_ring_reg << 16;
> -	WREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_64,
> psp_ring_reg);
> -	/* Wait for response flag (bit 31) in C2PMSG_64 */
> -	psp_ring_reg = 0;
> -	while ((psp_ring_reg & 0x80000000) == 0) {
> -		psp_ring_reg = RREG32_SOC15(MP0, 0,
> mmMP0_SMN_C2PMSG_64);
> -	}
> -
>  	return 0;
>  }
> 
> --
> 1.9.1
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx


More information about the amd-gfx mailing list