[PATCH] drm/amdgpu: fix the incorrect scratch reg number on gfx v9

Zhang, Jerry (Junwei) Jerry.Zhang at amd.com
Thu Jul 20 02:46:32 UTC 2017


On 07/20/2017 10:21 AM, Huang Rui wrote:
> There are 8 scratch registers on gfx v9 (scrach_reg0 -> scratch_reg7).

Yeah, nice catch.
Reviewed-by: Junwei Zhang <Jerry.Zhang at amd.com>

Additionally it looks incorrect from gfx v6 till gfx9.
Could you fix them all?

Jerry

>
> Signed-off-by: Huang Rui <ray.huang at amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
> index 48b43ea..4d7f042 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
> @@ -211,7 +211,7 @@ static void gfx_v9_0_init_golden_registers(struct amdgpu_device *adev)
>
>   static void gfx_v9_0_scratch_init(struct amdgpu_device *adev)
>   {
> -	adev->gfx.scratch.num_reg = 7;
> +	adev->gfx.scratch.num_reg = 8;
>   	adev->gfx.scratch.reg_base = SOC15_REG_OFFSET(GC, 0, mmSCRATCH_REG0);
>   	adev->gfx.scratch.free_mask = (1u << adev->gfx.scratch.num_reg) - 1;
>   }
>


More information about the amd-gfx mailing list