Re: 答复: [PATCH 1/4] drm/amdgpu/gmc6: disable legacy vga features in gmc init (v2)

[Harry Wentland]

Not an expert on GMC but this seems to be the best place to disable VGA
render.

Series is Acked-by: Harry Wentland <harry.wentland at amd.com>

Harry

On 2017-07-25 06:12 AM, Christian König wrote:
> The term "legacy VGA" sounds like the whole render functionality which
> actually isn't part of the GMC AFAIK.
> 
> But what Alex primary disables here is the old VGA BAR in the CPU
> address space and that is part of the GMC (or at least related to it).
> 
> BTW: Patch are Acked-by: Christian König <christian.koenig at amd.com>.
> 
> Christian.
> 
> Am 25.07.2017 um 11:26 schrieb Qu, Jim:
>> Hi Christian:
>>
>> Could you share your minds when you are on second glance?
>>
>> Thanks
>> JimQu
>>
>> ________________________________________
>> 发件人: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> 代表 Christian
>> König <deathsimple at vodafone.de>
>> 发送时间: 2017年7月25日 17:17
>> 收件人: Alex Deucher; amd-gfx at lists.freedesktop.org
>> 抄送: Deucher, Alexander
>> 主题: Re: [PATCH 1/4] drm/amdgpu/gmc6: disable legacy vga features in
>> gmc init (v2)
>>
>> Am 25.07.2017 um 05:30 schrieb Alex Deucher:
>>> Needs to be done when the MC is set up.
>>>
>>> v2: make consistent with other asics
>>>
>>> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
>> On first glance it kind of looks a bit odd to have that in the GMC code,
>> but on second glance it actually makes sense.
>>
>> Christian.
>>
>>> ---
>>>    drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c | 14 +++++++++++++-
>>>    1 file changed, 13 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c
>>> b/drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c
>>> index 117c4835..ab0a104 100644
>>> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c
>>> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c
>>> @@ -249,7 +249,19 @@ static void gmc_v6_0_mc_program(struct
>>> amdgpu_device *adev)
>>>                dev_warn(adev->dev, "Wait for MC idle timedout !\n");
>>>        }
>>>
>>> -     WREG32(mmVGA_HDP_CONTROL,
>>> VGA_HDP_CONTROL__VGA_MEMORY_DISABLE_MASK);
>>> +     if (adev->mode_info.num_crtc) {
>>> +             u32 tmp;
>>> +
>>> +             /* Lockout access through VGA aperture*/
>>> +             tmp = RREG32(mmVGA_HDP_CONTROL);
>>> +             tmp |= VGA_HDP_CONTROL__VGA_MEMORY_DISABLE_MASK;
>>> +             WREG32(mmVGA_HDP_CONTROL, tmp);
>>> +
>>> +             /* disable VGA render */
>>> +             tmp = RREG32(mmVGA_RENDER_CONTROL);
>>> +             tmp &= ~VGA_VSTATUS_CNTL;
>>> +             WREG32(mmVGA_RENDER_CONTROL, tmp);
>>> +     }
>>>        /* Update configuration */
>>>        WREG32(mmMC_VM_SYSTEM_APERTURE_LOW_ADDR,
>>>               adev->mc.vram_start >> 12);
>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
> 
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx