[PATCH 15/81] drm/amd/display: Re-enable Vsync Interrupts for Gradual Refresh Ramp

Michel Dänzer michel at daenzer.net
Thu Jul 27 00:15:17 UTC 2017


On 26/07/17 10:34 PM, Harry Wentland wrote:
> On 2017-07-25 09:34 PM, Michel Dänzer wrote:
>> On 25/07/17 10:53 PM, sunpeng.li at amd.com wrote:
>>> From: Amy Zhang <Amy.Zhang at amd.com>
>>>
>>> - Make sure Vsync interrupts are disabled in static screen case
>>>   and enabled when not to save power
>>
>> What exactly does this mean? FWIW, the interrupt whose handler calls
>> drm_handle_vblank() must be enabled from when the
>> drm_driver::enable_vblank hook is called until when the
>> drm_driver::disable_vblank hook is called.
> 
> This comment is misleading and should've been trimmed when preparing the
> patches for the open tree. This change should not have an impact on
> vblank interrupts on Linux.

That's good to know.

> Sorry for the confusion.

No worries, just making sure.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer


More information about the amd-gfx mailing list