[PATCH 2/2] drm/amdgpu: Support IOMMU on Raven

Christian König deathsimple at vodafone.de
Thu Jul 27 09:38:07 UTC 2017


Am 26.07.2017 um 22:46 schrieb Yong Zhao:
> We achieved that by setting the PTEs to 2 (the SYSTEM bit is set) when
> the corresponding addresses are not occupied by gpu driver allocated
> buffers.
>
> Change-Id: I995c11c7a25bdaf7a16700d9e08a8fe287d49417
> Signed-off-by: Yong Zhao <Yong.Zhao at amd.com>

[SNIP]

> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.h
> index 833b172..4271243 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.h
> @@ -132,14 +132,16 @@ int amdgpu_bo_create(struct amdgpu_device *adev,
>   			    bool kernel, u32 domain, u64 flags,
>   			    struct sg_table *sg,
>   			    struct reservation_object *resv,
> -			    struct amdgpu_bo **bo_ptr);
> +			    struct amdgpu_bo **bo_ptr,
> +			    uint64_t init_value);
Two comments here: The new parameter init_value should come before 
bo_ptr, cause bo_ptr is the result of the function. And please split up 
that change into a separate patch.

Apart from that the change looks good to me,
Christian.


More information about the amd-gfx mailing list