[PATCH] drm/amdgpu: disable vcn power control for now

[Christian König]

Am 27.07.2017 um 19:04 schrieb Alex Deucher:
> On Thu, Jul 27, 2017 at 12:17 PM, Leo Liu <leo.liu at amd.com> wrote:
>> The dpm control for vcn has been moved to firmware, kernel always spins
>> "amdgpu: [powerplay] pp_dpm_powergate_uvd was not implemented", each
>> time when application runs, disable it for now till pg/cg. Also remove
>> clock manual setting when dpm disabled, which was inherited from uvd.
>>
>> Signed-off-by: Leo Liu <leo.liu at amd.com>
> Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

Reviewed-by: Christian König <christian.koenig at amd.com>

>
>> ---
>>   drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 14 ++++++--------
>>   1 file changed, 6 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c
>> index 09190fa..d58ca82 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c
>> @@ -209,9 +209,9 @@ static void amdgpu_vcn_idle_work_handler(struct work_struct *work)
>>
>>          if (fences == 0) {
>>                  if (adev->pm.dpm_enabled) {
>> +                       /* might be used when with pg/cg
>>                          amdgpu_dpm_enable_uvd(adev, false);
>> -               } else {
>> -                       amdgpu_asic_set_uvd_clocks(adev, 0, 0);
>> +                       */
>>                  }
>>          } else {
>>                  schedule_delayed_work(&adev->vcn.idle_work, VCN_IDLE_TIMEOUT);
>> @@ -223,12 +223,10 @@ void amdgpu_vcn_ring_begin_use(struct amdgpu_ring *ring)
>>          struct amdgpu_device *adev = ring->adev;
>>          bool set_clocks = !cancel_delayed_work_sync(&adev->vcn.idle_work);
>>
>> -       if (set_clocks) {
>> -               if (adev->pm.dpm_enabled) {
>> -                       amdgpu_dpm_enable_uvd(adev, true);
>> -               } else {
>> -                       amdgpu_asic_set_uvd_clocks(adev, 53300, 40000);
>> -               }
>> +       if (set_clocks && adev->pm.dpm_enabled) {
>> +               /* might be used when with pg/cg
>> +               amdgpu_dpm_enable_uvd(adev, true);
>> +               */
>>          }
>>   }
>>
>> --
>> 2.7.4
>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx