[PATCH] drm/amdgpu: make wb 256bit function names consistent

Christian König deathsimple at vodafone.de
Fri Jul 28 09:04:33 UTC 2017


Am 27.07.2017 um 22:43 schrieb Alex Deucher:
> Use a lower case b to be consistent with the other wb functions.
>
> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>

I still suggest to get rid of all those variants and always allocate 
256bits, but anyway the patch is Reviewed-by: Christian König 
<christian.koenig at amd.com>.

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu.h        | 2 +-
>   drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
>   drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c   | 2 +-
>   3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> index f364900..5f8d2e8 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> @@ -1192,7 +1192,7 @@ struct amdgpu_wb {
>   int amdgpu_wb_get(struct amdgpu_device *adev, u32 *wb);
>   void amdgpu_wb_free(struct amdgpu_device *adev, u32 wb);
>   int amdgpu_wb_get_64bit(struct amdgpu_device *adev, u32 *wb);
> -int amdgpu_wb_get_256Bit(struct amdgpu_device *adev, u32 *wb);
> +int amdgpu_wb_get_256bit(struct amdgpu_device *adev, u32 *wb);
>   void amdgpu_wb_free_64bit(struct amdgpu_device *adev, u32 wb);
>   void amdgpu_wb_free_256bit(struct amdgpu_device *adev, u32 wb);
>   
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 06c214f..41f6af3 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -602,7 +602,7 @@ int amdgpu_wb_get_64bit(struct amdgpu_device *adev, u32 *wb)
>   	}
>   }
>   
> -int amdgpu_wb_get_256Bit(struct amdgpu_device *adev, u32 *wb)
> +int amdgpu_wb_get_256bit(struct amdgpu_device *adev, u32 *wb)
>   {
>   	int i = 0;
>   	unsigned long offset = bitmap_find_next_zero_area_off(adev->wb.used,
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c
> index 15b7149..3874be8 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c
> @@ -213,7 +213,7 @@ int amdgpu_ring_init(struct amdgpu_device *adev, struct amdgpu_ring *ring,
>   	}
>   
>   	if (amdgpu_sriov_vf(adev) && ring->funcs->type == AMDGPU_RING_TYPE_GFX) {
> -		r = amdgpu_wb_get_256Bit(adev, &ring->fence_offs);
> +		r = amdgpu_wb_get_256bit(adev, &ring->fence_offs);
>   		if (r) {
>   			dev_err(adev->dev, "(%d) ring fence_offs wb alloc failed\n", r);
>   			return r;




More information about the amd-gfx mailing list