[PATCH 18/18] drm/amdgpu: fix the gart table cleared issue for S3
Huang Rui
ray.huang at amd.com
Thu Jun 1 01:49:20 UTC 2017
On Thu, Jun 01, 2017 at 12:58:02AM +0800, Koenig, Christian wrote:
> Am 31.05.2017 um 18:29 schrieb Deucher, Alexander:
>
> > -----Original Message-----
> > From: amd-gfx [mailto:amd-gfx-bounces at lists.freedesktop.org] On Behalf
> > Of Huang Rui
> > Sent: Wednesday, May 31, 2017 12:15 PM
> > To: amd-gfx at lists.freedesktop.org; Deucher, Alexander; Koenig, Christian
> > Cc: Wang, Ken; Huang, Ray; Huan, Alvin
> > Subject: [PATCH 18/18] drm/amdgpu: fix the gart table cleared issue for
> S3
> >
> > Signed-off-by: Huang Rui <ray.huang at amd.com>
> > ---
> > drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 +
> > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +-
> > drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c | 2 ++
> > drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c | 2 ++
> > drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 2 ++
> > drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 3 +++
> > 6 files changed, 11 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> > b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> > index 37f9869..50ed985 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> > @@ -624,6 +624,7 @@ struct amdgpu_mc {
> > uint32_t srbm_soft_reset;
> > struct amdgpu_mode_mc_save save;
> > bool prt_warning;
> > + unsigned long stollen_size;
>
> Typo: stolen_size
> With that fixed:
> Reviewed-by: Alex Deucher <alexander.deucher at amd.com>
>
>
> Additional to that this should be an uint64_t otherwise 32bit systems will
> break.
>
> Please also add a "/* TODO: Figure out how to avoid that... */ to setting the
> size to 8MB on Vega10.
>
> With that fixed Reviewed-by: Christian König <christian.koenig at amd.com>.
>
OK, will fix that.
Thanks,
Ray
More information about the amd-gfx
mailing list