number of rings broken

Tom St Denis tom.stdenis at amd.com
Mon Jun 5 15:35:03 UTC 2017


On 05/06/17 11:32 AM, Alex Deucher wrote:
> On Mon, Jun 5, 2017 at 7:34 AM, Tom St Denis <tom.stdenis at amd.com> wrote:
>> Hi all,
>>
>> Just back after a week off ... first thing I see on my vega10 system is this
>> patch:
>>
>> 83866f0fc72017d55f40cbd4160cd1e42a2cc3a8 is the first bad commit
>> commit 83866f0fc72017d55f40cbd4160cd1e42a2cc3a8
>> Author: Andres Rodriguez <andresx7 at gmail.com>
>> Date:   Thu Feb 2 00:38:22 2017 -0500
>>
>>      drm/amdgpu: allow split of queues with kfd at queue granularity v4
>>
>>      Previously the queue/pipe split with kfd operated with pipe
>>      granularity. This patch allows amdgpu to take ownership of an arbitrary
>>      set of queues.
>>
>>      It also consolidates the last few magic numbers in the compute
>>      initialization process into mec_init.
>>
>>      v2: support for gfx9
>>      v3: renamed AMDGPU_MAX_QUEUES to AMDGPU_MAX_COMPUTE_QUEUES
>>      v4: fix off-by-one in num_mec checks in *_compute_queue_acquire
>>
>>      Reviewed-by: Edward O'Callaghan <funfunctor at folklore1984.net>
>>      Reviewed-by: Felix Kuehling <Felix.Kuehling at amd.com>
>>      Acked-by: Christian König <christian.koenig at amd.com>
>>      Signed-off-by: Andres Rodriguez <andresx7 at gmail.com>
>>      Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
>>
>> :040000 040000 cafdad84e9fd950112e9ff56956526fa47dcaa59
>> 48647a91855c0b2d4b3dfedffb89bd93da25c0eb M      drivers
> 
> Looks like some of Andres' later patches were not properly rebased for
> gfx9.  Do to the two patches I send out this morning help?

By visual inspection patch 1/2 seems to copy the patch I sent to the 
list this morning. I'll apply both on top of stg-4.11 and see what pops out.

Cheers,
Tom


More information about the amd-gfx mailing list