On 09/06/17 10:23 AM, Deucher, Alexander wrote: >> Could use WREG32_FIELD() here to simplify these. > > That doesn't work if you have variable register names as we do in this case. Which is why we have WREG32_FIELD_OFFSET :-) Tom