[PATCH] amdgpu: Set cik/si_support to 1 by default if radeon isn't built

Alex Deucher alexdeucher at gmail.com
Fri Jun 30 14:09:39 UTC 2017


On Fri, Jun 30, 2017 at 4:36 AM, Michel Dänzer <michel at daenzer.net> wrote:
> From: Michel Dänzer <michel.daenzer at amd.com>
>
> It was required to explicitly set these parameters to 1, even if the
> radeon driver isn't built at all, which is not intuitive.
>
> Reported-by: Shawn Starr <shawn.starr at rogers.com>
> Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>

Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> index 27599db7d630..58770fc40520 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> @@ -234,14 +234,28 @@ MODULE_PARM_DESC(param_buf_per_se, "the size of Off-Chip Pramater Cache per Shad
>  module_param_named(param_buf_per_se, amdgpu_param_buf_per_se, int, 0444);
>
>  #ifdef CONFIG_DRM_AMDGPU_SI
> +
> +#if defined(CONFIG_DRM_RADEON) || defined(CONFIG_DRM_RADEON_MODULE)
>  int amdgpu_si_support = 0;
>  MODULE_PARM_DESC(si_support, "SI support (1 = enabled, 0 = disabled (default))");
> +#else
> +int amdgpu_si_support = 1;
> +MODULE_PARM_DESC(si_support, "SI support (1 = enabled (default), 0 = disabled)");
> +#endif
> +
>  module_param_named(si_support, amdgpu_si_support, int, 0444);
>  #endif
>
>  #ifdef CONFIG_DRM_AMDGPU_CIK
> +
> +#if defined(CONFIG_DRM_RADEON) || defined(CONFIG_DRM_RADEON_MODULE)
>  int amdgpu_cik_support = 0;
>  MODULE_PARM_DESC(cik_support, "CIK support (1 = enabled, 0 = disabled (default))");
> +#else
> +int amdgpu_cik_support = 1;
> +MODULE_PARM_DESC(cik_support, "CIK support (1 = enabled (default), 0 = disabled)");
> +#endif
> +
>  module_param_named(cik_support, amdgpu_cik_support, int, 0444);
>  #endif
>
> --
> 2.13.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx


More information about the amd-gfx mailing list