[PATCH 14/15] drm/amd/display: Enable warnings as errors

Emil Velikov emil.l.velikov at gmail.com
Wed Mar 1 01:20:36 UTC 2017


Hi Harry,

On 1 March 2017 at 00:26, Harry Wentland <harry.wentland at amd.com> wrote:
> Change-Id: I48d38e4d0224c9f0e52055b3c4ddef8e872b3dac
> Signed-off-by: Harry Wentland <harry.wentland at amd.com>
> Acked-by: Harry Wentland <Harry.Wentland at amd.com>
> Reviewed-by: Jordan Lazare <Jordan.Lazare at amd.com>
> Reviewed-by: Tony Cheng <Tony.Cheng at amd.com>
> ---
>  drivers/gpu/drm/amd/display/Makefile | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/display/Makefile b/drivers/gpu/drm/amd/display/Makefile
> index 8ba37dd9cf7f..c22475b55586 100644
> --- a/drivers/gpu/drm/amd/display/Makefile
> +++ b/drivers/gpu/drm/amd/display/Makefile
> @@ -5,6 +5,8 @@
>
>  AMDDALPATH = $(RELATIVE_AMD_DISPLAY_PATH)
>
> +subdir-ccflags-y += -Werror
> +
Many kernel modules have tried this in the past and had to quickly
revert it. There's far too many compiler/toolchain combinations for
this to always be true.

By adding this you'll be adding serious annoyance to users and extra
burden on Alex.

-Emil


More information about the amd-gfx mailing list