[PATCH xf86-video-ati 2/2] Pass TRUE to drmmode_set_desired_modes the first time for GPU screens

Alex Deucher alexdeucher at gmail.com
Thu Mar 9 03:57:12 UTC 2017


On Wed, Mar 8, 2017 at 4:03 AM, Michel Dänzer <michel at daenzer.net> wrote:
> From: Michel Dänzer <michel.daenzer at amd.com>
>
> This is the only place we call drmmode_set_desired_modes for GPU screens
> during server startup. Without this change, the display outputs of
> secondary GPUs may stay on even while Xorg isn't using them.
>
> Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>

Series is:
Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>
> I recently made essentially the reverse change in the amdgpu driver,
> but realized later that this is needed for the reason described in the
> commit log.
>
>  src/radeon_kms.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/radeon_kms.c b/src/radeon_kms.c
> index 907ebfcff..424f9f724 100644
> --- a/src/radeon_kms.c
> +++ b/src/radeon_kms.c
> @@ -328,7 +328,8 @@ static Bool RADEONCreateScreenResources_KMS(ScreenPtr pScreen)
>         }
>      }
>
> -    if (!drmmode_set_desired_modes(pScrn, &info->drmmode, FALSE))
> +    if (!drmmode_set_desired_modes(pScrn, &info->drmmode,
> +                                  radeon_is_gpu_screen(pScreen)))
>         return FALSE;
>
>      drmmode_uevent_init(pScrn, &info->drmmode);
> --
> 2.11.0
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx


More information about the amd-gfx mailing list