[PATCH 4/4] drm/amdgpu:enable MCBP for SR-IOV

Christian König deathsimple at vodafone.de
Thu Mar 9 13:15:09 UTC 2017


You need a commit message here. Something like "apply the new IB flag 
during command submission".

Am 08.03.2017 um 08:54 schrieb Monk Liu:
> Change-Id: I779abc6a47593be0ff5234c3e2f2cdfd25ba70ca
> Signed-off-by: Monk Liu <Monk.Liu at amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
> index 8dba5ff..be49c30 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
> @@ -6552,6 +6552,10 @@ static void gfx_v8_0_ring_emit_ib_gfx(struct amdgpu_ring *ring,
>   
>   	control |= ib->length_dw | (vm_id << 24);
>   
> +	if (ring && amdgpu_sriov_vf(ring->adev) &&
> +		ib->flags & AMDGPU_IB_FLAG_PREEMPT)
> +		control |= (1<<21);
> +

The check for ring being NULL is superfluous and the indentation of the 
"ib->flags & AMDGPU_IB_FLAG_PREEMPT" is wrong.

Apart from that the series is Reviewed-by: Christian König 
<christian.koenig at amd.com>.

Christian

>   	amdgpu_ring_write(ring, header);
>   	amdgpu_ring_write(ring,
>   #ifdef __BIG_ENDIAN




More information about the amd-gfx mailing list