[PATCH] drm/amd/amdgpu: Fix debugfs reg read/write address width

Christian König deathsimple at vodafone.de
Wed Mar 15 09:37:20 UTC 2017


Am 15.03.2017 um 10:35 schrieb Tom St Denis:
> The MMIO space is wider now so we mask the lower 22 bits
> instead of 18.
>
> Signed-off-by: Tom St Denis <tom.stdenis at amd.com>

Reviewed-by: Christian König <christian.koenig at amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 47d1dcc85b18..89504a883791 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -2944,7 +2944,7 @@ static ssize_t amdgpu_debugfs_regs_read(struct file *f, char __user *buf,
>   		use_bank = 0;
>   	}
>   
> -	*pos &= 0x3FFFF;
> +	*pos &= (1UL << 22) - 1;
>   
>   	if (use_bank) {
>   		if ((sh_bank != 0xFFFFFFFF && sh_bank >= adev->gfx.config.max_sh_per_se) ||
> @@ -3020,7 +3020,7 @@ static ssize_t amdgpu_debugfs_regs_write(struct file *f, const char __user *buf,
>   		use_bank = 0;
>   	}
>   
> -	*pos &= 0x3FFFF;
> +	*pos &= (1UL << 22) - 1;
>   
>   	if (use_bank) {
>   		if ((sh_bank != 0xFFFFFFFF && sh_bank >= adev->gfx.config.max_sh_per_se) ||




More information about the amd-gfx mailing list