[PATCH] drm/amdgpu: fix vm pte pde flags to 64-bit for sdma v4
Christian König
deathsimple at vodafone.de
Tue Mar 28 10:06:16 UTC 2017
Am 28.03.2017 um 10:55 schrieb Junwei Zhang:
> Signed-off-by: Junwei Zhang <Jerry.Zhang at amd.com>
Good catch, patch is Reviewed-by: Christian König
<christian.koenig at amd.com>.
It doesn't matter for older versions because they don't have flags in
the high bits, but just for completeness could you fix this for them as
well?
Thanks,
Christian.
> ---
> drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
> index dcbef50..6cfb100 100644
> --- a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
> @@ -968,8 +968,8 @@ static void sdma_v4_0_vm_set_pte_pde(struct amdgpu_ib *ib,
> ib->ptr[ib->length_dw++] = SDMA_PKT_HEADER_OP(SDMA_OP_PTEPDE);
> ib->ptr[ib->length_dw++] = lower_32_bits(pe); /* dst addr */
> ib->ptr[ib->length_dw++] = upper_32_bits(pe);
> - ib->ptr[ib->length_dw++] = flags; /* mask */
> - ib->ptr[ib->length_dw++] = 0;
> + ib->ptr[ib->length_dw++] = lower_32_bits(flags); /* mask */
> + ib->ptr[ib->length_dw++] = upper_32_bits(flags);
> ib->ptr[ib->length_dw++] = lower_32_bits(addr); /* value */
> ib->ptr[ib->length_dw++] = upper_32_bits(addr);
> ib->ptr[ib->length_dw++] = incr; /* increment size */
More information about the amd-gfx
mailing list