[PATCH 3/6] drm/amdgpu: don't clean the framebuffer for VF

Ding, Pixel Pixel.Ding at amd.com
Thu May 4 08:14:50 UTC 2017


This patch is not necessary since FB is already cleaned by GPU.
— 
Sincerely Yours,
Pixel








On 04/05/2017, 3:30 PM, "Liu, Monk" <Monk.Liu at amd.com> wrote:

>NAK
>
>This behavior that Hypervisor cleans framebuffer for each VF is only on AWS, 
>Regular GIM doesn't clean framebuffer after FLR, so guest driver still need this cleaning,
>
>Please keep this patch in your AWS branch only.
>
>BR Monk
>
>-----Original Message-----
>From: amd-gfx [mailto:amd-gfx-bounces at lists.freedesktop.org] On Behalf Of Xiangliang Yu
>Sent: Thursday, May 04, 2017 2:34 PM
>To: amd-gfx at lists.freedesktop.org
>Cc: Ding, Pixel <Pixel.Ding at amd.com>; Yu, Xiangliang <Xiangliang.Yu at amd.com>
>Subject: [PATCH 3/6] drm/amdgpu: don't clean the framebuffer for VF
>
>From: Pixel Ding <Pixel.Ding at amd.com>
>
>The SRIOV host driver cleans framebuffer for each VF, guest driver needn't this action which costs much time on some virtualization platform, otherwise it might get timeout to initialize.
>
>Signed-off-by: Pixel Ding <Pixel.Ding at amd.com>
>Signed-off-by: Xiangliang Yu <Xiangliang.Yu at amd.com>
>---
> drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c
>index e869e60..6f5d994 100644
>--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c
>+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c
>@@ -242,6 +242,9 @@ static int amdgpufb_create(struct drm_fb_helper *helper,
> 	/* setup helper */
> 	rfbdev->helper.fb = fb;
> 
>+	if (!amdgpu_sriov_vf(adev))
>+		memset_io(abo->kptr, 0x0, amdgpu_bo_size(abo));
>+
> 	strcpy(info->fix.id, "amdgpudrmfb");
> 
> 	drm_fb_helper_fill_fix(info, fb->pitches[0], fb->depth);
>--
>2.7.4
>
>_______________________________________________
>amd-gfx mailing list
>amd-gfx at lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/amd-gfx


More information about the amd-gfx mailing list