[PATCH] drm/amdgpu: fix errors in comments.

Xie, AlexBin AlexBin.Xie at amd.com
Tue May 9 01:29:19 UTC 2017


Hi Michel,


The code change has been submitted into our internal git server.

I have a follow up commit in another email thread.

The commit fixes more errors in comments.


Thanks,

Alex Bin

________________________________
From: Michel Dänzer <michel at daenzer.net>
Sent: Monday, May 8, 2017 9:13 PM
To: Xie, AlexBin
Cc: amd-gfx at lists.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu: fix errors in comments.

On 09/05/17 12:32 AM, Alex Xie wrote:
> Signed-off-by: Alex Xie <AlexBin.Xie at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 66bb60e..aab3206 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -479,9 +479,8 @@ void amdgpu_doorbell_get_kfd_info(struct amdgpu_device *adev,
>
>  /*
>   * amdgpu_wb_*()
> - * Writeback is the the method by which the the GPU updates special pages
> - * in memory with the status of certain GPU events (fences, ring pointers,
> - * etc.).
> + * Writeback is the method by which GPU updates special pages in memory

This should still say "the GPU".


> + * with the status of certain GPU events (fences, ring pointers,etc.).
>   */
>
>  /**
> @@ -507,7 +506,7 @@ static void amdgpu_wb_fini(struct amdgpu_device *adev)
>   *
>   * @adev: amdgpu_device pointer
>   *
> - * Disables Writeback and frees the Writeback memory (all asics).
> + * Initialize writeback and allocates writeback memory (all asics).

For consistency, this should say either "Initialize writeback and
allocate writeback memory" or "Initializes writeback and allocates
writeback memory".


--
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20170509/3573660f/attachment.html>


More information about the amd-gfx mailing list