[PATCH] drm/amdgpu: fix errors in comments.

William Lewis minutemaidpark at hotmail.com
Mon May 8 19:23:35 UTC 2017



On 05/08/2017 10:32 AM, Alex Xie wrote:
> Signed-off-by: Alex Xie <AlexBin.Xie at amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 +++----
>   1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 66bb60e..aab3206 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -479,9 +479,8 @@ void amdgpu_doorbell_get_kfd_info(struct amdgpu_device *adev,
>   
>   /*
>    * amdgpu_wb_*()
> - * Writeback is the the method by which the the GPU updates special pages
> - * in memory with the status of certain GPU events (fences, ring pointers,
> - * etc.).
> + * Writeback is the method by which GPU updates special pages in memory
You took out three instances of "the" instead of just two.
* Writeback is the method by which the GPU updates special pages in memory.
> + * with the status of certain GPU events (fences, ring pointers,etc.).
And you took out a space that made it slightly more legible here.
* with the status of certain GPU events (fences, ring pointers, etc.).
>    */
>   
>   /**
> @@ -507,7 +506,7 @@ static void amdgpu_wb_fini(struct amdgpu_device *adev)
>    *
>    * @adev: amdgpu_device pointer
>    *
> - * Disables Writeback and frees the Writeback memory (all asics).
> + * Initialize writeback and allocates writeback memory (all asics).
Inconsistent.
* Initializes writeback and allocates writeback memory (all asics).
>    * Used at driver startup.
>    * Returns 0 on success or an -error on failure.
>    */



More information about the amd-gfx mailing list